Added support for config_data #2195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BBBmau
reviewed
Feb 7, 2024
|
@eduanb pinging to be able to get a test config for this. |
BBBmau
reviewed
Jul 26, 2024
kubernetes/provider.go
Outdated
| Optional: true, | ||
| Sensitive: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("KUBE_CONFIG_DATA", nil), | ||
| Description: "Raw kube config data for the kubernetes provider", |
There was a problem hiding this comment.
initially when running this locally the provider would fail to build due to the descriptions not being the same between kubernetes/provider.go and manifest/provider_config.go
After making some adjustments as well removing ConflictsWith, I was able to produce working applies where i used the local provider to test the new field.
A test would be great to include, we'll also want to include this in the kubernetes documentation and finally a changlog generation. Let me know if help is needed to get this PR in a mergable state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows you to send in the raw kubeconfig data without first creating a temp file.
Closes #1735
Note: I have very little Go experience, so please let me know if I need to change things. Would greatly appreciate it if someone could help with writing a test for this.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note